Memoize the block_sync_enabled? call for FacilitiesController

simpledotorg · Dec 17, 2020 · e424312 · e424312
1 parent 7cf2e40
commit e424312
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/app/controllers/api/v3/facilities_controller.rb b/app/controllers/api/v3/facilities_controller.rb
@@ -52,8 +52,15 @@ def records_to_sync
 
   private
 
+  # Memoize this call here so that we don't end up making thousands of calls to check user for each facility
+  # Ignore nil values
+  def block_level_sync?
+    @is_block_level_sync_enabled = current_user&.block_level_sync? if @is_block_level_sync_enabled.nil?
+    @is_block_level_sync_enabled
+  end
+
   def sync_region_id(facility)
-    if current_user&.block_level_sync?
+    if block_level_sync?
       facility.block_region_id
     else
       facility.facility_group_id