Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to include hosted IDPs in the list? #14

Open
madsi1m opened this issue Jul 5, 2023 · 7 comments
Open

Possible to include hosted IDPs in the list? #14

madsi1m opened this issue Jul 5, 2023 · 7 comments

Comments

@madsi1m
Copy link

madsi1m commented Jul 5, 2023

Hi, is it possible to also include saml20-idp-hosted IDPs in the disco list?

At the moment it only shows what is in saml20-idp-remote.

Cheers

@thijskh
Copy link
Member

thijskh commented Jul 6, 2023

Does it actually work if you would select such an IdP?

@madsi1m
Copy link
Author

madsi1m commented Jul 6, 2023

I do not know because the hosted idp is not in the list

@ghalse
Copy link
Collaborator

ghalse commented Jul 6, 2023

I don't believe this will work the way you're hoping. If you're running an IdP and an SP on the same web server, copy the IdP's generated metadata into saml20-idp-remote.php to configure the SP. Then it'll appear in discovery.

@thijskh
Copy link
Member

thijskh commented Jul 6, 2023

That makes sense to me. Rather make configuration explicit: list the IdPs you want in saml20-idp-remote rather than 'magically' making login also possible for any local IdPs - not quite sure that this would not lead to various surprises.

@tvdijen
Copy link
Member

tvdijen commented Jul 6, 2023

I think it would be a nice feature.. It's just a matter of writing proper upgrade notes.

@ghalse
Copy link
Collaborator

ghalse commented Jul 7, 2023

I think it would be a nice feature.. It's just a matter of writing proper upgrade notes.

IMHO, that includes not turning the feature on by default.

But it also occurs to me it is solved simply by documentation.

We do exactly what I suggested earlier, and the metadata in samls20-idp-hosted.php and saml20-idp-remote.php is not identical (particularly around authproc filters and the mdui dressing). So there's also some value in the status quo.

@tvdijen
Copy link
Member

tvdijen commented Jul 7, 2023

authproc-filters are irrelevant for this purpose and mdui settings should be identical? Can you explain what the difference is?
We can literally fix this with a oneliner, so I would be in favour to 'fix' this rather then to document the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants