From 4e98678e257b24f0f6b4cb0a9b357bdfb90dec1b Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tim.dijen@minbzk.nl>
Date: Mon, 27 May 2019 13:59:11 +0200
Subject: [PATCH] Address Psalm issues

---
 lib/Auth/Process/SmartID.php   | 9 +--------
 lib/Auth/Process/SmartName.php | 8 --------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/lib/Auth/Process/SmartID.php b/lib/Auth/Process/SmartID.php
index 7d43545..c8d5909 100644
--- a/lib/Auth/Process/SmartID.php
+++ b/lib/Auth/Process/SmartID.php
@@ -45,13 +45,6 @@ class SmartID extends \SimpleSAML\Auth\ProcessingFilter
      */
     private $add_candidate = true;
 
-    /**
-     * Attributes which should be added/appended.
-     *
-     * @var array Associative array of arrays.
-     */
-    private $attributes = [];
-
 
     /**
      * @param array $config
@@ -138,7 +131,7 @@ public function process(&$request)
 
         $id = $this->addID($request['Attributes'], $request);
 
-        if (isset($id)) {
+        if (!empty($id)) {
             $request['Attributes'][$this->id_attribute] = [$id];
         }
     }
diff --git a/lib/Auth/Process/SmartName.php b/lib/Auth/Process/SmartName.php
index 0db805d..42be638 100644
--- a/lib/Auth/Process/SmartName.php
+++ b/lib/Auth/Process/SmartName.php
@@ -12,14 +12,6 @@
  */
 class SmartName extends \SimpleSAML\Auth\ProcessingFilter
 {
-    /**
-     * Attributes which should be added/appended.
-     *
-     * @var array Associative array of arrays.
-     */
-    private $attributes = [];
-
-
     /**
      * @param array $attributes
      * @return string|null