Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Prepare CloudFormation templates and any additional adjustments for deployment #20 #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jplippi
Copy link
Contributor

@jplippi jplippi commented Dec 10, 2021

Closes #20

@jplippi jplippi requested a review from melanke December 10, 2021 03:26
Copy link
Member

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to need to use env variables

@@ -1,5 +1,5 @@
overwrite: true
schema: 'http://localhost:3000/api/graphql' # GraphQL endpoint via the apollo server
schema: 'https://usecase.dev.simpli.com.br/api/graphql' # GraphQL endpoint via the apollo server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not gonna work on development environments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we can use env variables on this file aswell:
dotansimha/graphql-code-generator#1302 (comment)

@@ -4,7 +4,7 @@ import fetch from 'isomorphic-unfetch'
import { getToken } from 'state/AuthState'

// the URL to /api/graphql
const GRAPHQL_ENDPOINT = 'http://localhost:3000/api/graphql'
const GRAPHQL_ENDPOINT = 'https://usecase.dev.simpli.com.br/api/graphql'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be placed on the .env file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare CloudFormation templates and any additional adjustments for deployment
2 participants