Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enums for viewer and conversion status constants #455

Closed
interim17 opened this issue Dec 13, 2023 · 0 comments · Fixed by #521
Closed

Use enums for viewer and conversion status constants #455

interim17 opened this issue Dec 13, 2023 · 0 comments · Fixed by #521
Assignees
Labels
maintenance Code cleanup/refactoring, test coverage, etc.

Comments

@interim17
Copy link
Contributor

What needs to happen?

Convert some types and constants to enums

Why should we do this?

During review on autoconersion, @ShrimpCryptid pointed out that it would be efficient and readable to use an enum where we currently use types in some cases, notably viewer status and conversionStatus. When converting these, we should also check for other opportunities to include legibility and efficiency of typing in the website repo.

When does this need to get done?

Not urgent, appropriate to fold into auto-conversion work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code cleanup/refactoring, test coverage, etc.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant