Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load from url input is right justified #464

Closed
meganrm opened this issue Feb 14, 2024 · 4 comments · Fixed by #466
Closed

Load from url input is right justified #464

meganrm opened this issue Feb 14, 2024 · 4 comments · Fixed by #466
Assignees
Labels
bug Something isn't working

Comments

@meganrm
Copy link
Contributor

meganrm commented Feb 14, 2024

Description

The "load from url" text input is formatted weirdly: it's right justified which is confusing.

Screenshot 2024-02-14 at 5 57 12 PM

Expected Behavior

I think this is the design. Although it might not be the most recent: @lynwilhelm can you make sure the right one is linked here?

Reproduction

A minimal example that exhibits the behavior.

Environment

Looks like this on chrome, safari and edge

@meganrm meganrm added the bug Something isn't working label Feb 14, 2024
@meganrm
Copy link
Contributor Author

meganrm commented Feb 14, 2024

I think what happened here is the "share trajectory" input is left justified to show the time param and that style got applied to the other modal too

@meganrm
Copy link
Contributor Author

meganrm commented Feb 14, 2024

it also look like there is an extra border

@lynwilhelm
Copy link
Contributor

Yes, that is the most current design. I am not partial to the hint text being a URL... or "Start typing..." but yes, it should be left justified. After the user input a URL however, I think it could be useful for the user to be able to see the end of that string (filename). I don't think that would require a right justify though.

@meganrm
Copy link
Contributor Author

meganrm commented Feb 15, 2024

Yes, that is the most current design. I am not partial to the hint text being a URL... or "Start typing..." but yes, it should be left justified. After the user input a URL however, I think it could be useful for the user to be able to see the end of that string (filename). I don't think that would require a right justify though.

Thanks! what should the hint text be?

This is what it looks like when you enter a url, they can be very long. we could pull out the file name and put it under the input box. For now I'm going to make it look like the current design (plus any change in the hint text you decide on). Let me know if you think we should make any other changes

Screenshot 2024-02-15 at 9 37 14 AM

@meganrm meganrm self-assigned this Feb 15, 2024
@meganrm meganrm mentioned this issue Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants