Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty drag and drop event render overlay #619

Closed
interim17 opened this issue Dec 6, 2024 · 0 comments · Fixed by #620
Closed

empty drag and drop event render overlay #619

interim17 opened this issue Dec 6, 2024 · 0 comments · Fixed by #620
Assignees
@interim17
Labels
bug Something isn't working

Comments

@interim17
Copy link
Contributor

Description

It's possible to trigger handleDragOverViewer when no file is being dragged, causing the overlay to render and get stuck like this:
Screenshot 2024-12-05 at 4 49 30 PM

Expected Behavior

The drag and drop overlay should only show up when a file is being dragged over.
@interim17 interim17 added the bug Something isn't working label Dec 6, 2024
@interim17 interim17 self-assigned this Dec 6, 2024
@interim17 interim17 moved this to 👓 In Review / Blocked in Simularium Planning Dec 6, 2024
@interim17 interim17 mentioned this issue Dec 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from 👓 In Review / Blocked to ✔ Done in Simularium Planning Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@interim17 interim17

Labels
bug Something isn't working
Projects
Simularium Planning
Status: ✔ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug fix: only load drag and drop overlay if drag event contains file simularium/simularium-website
1 participant
@interim17