Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Classic Support #5821

Open
1 of 17 tasks
seanpeters86 opened this issue Mar 1, 2021 · 12 comments
Open
1 of 17 tasks

EPIC: Classic Support #5821

seanpeters86 opened this issue Mar 1, 2021 · 12 comments

Comments

@seanpeters86
Copy link
Member

seanpeters86 commented Mar 1, 2021

Placeholder ticket meant to encompass the work required to get support for Classic Vanilla and/or TBC support into SimC. There are probably lots of things missing from this, but this is a good starting point for anyone interested. See the contribution file for more information on how to participate.

Base Module Work

The bulk of the work for any SimC expansion is mostly down to implementing each class spell in the class module and then subsequent APL work. In order for this work to even start a few prerequisites would be required.

  • Branch created for the version of the game, i.e. classic or tbc
  • Parsing game data into workable Spell Data (somewhat blocked until blizzard publishes client for TBC). Alternatively you could hard code this like it used to be done. Mage examples can be found here. Original TBC simc commit here.
  • Handling items/character stat integrations. Need to be able to import gear and have it have the correct stats/etc
  • Tier Set Bonus constructs. Need the class modules to be able to implement these
  • Talent tree support, currently this is just a talents=1231233 system that would need to be adjusted
  • Spell rank support (might be fine? but would need checking, including APL support if needed)
  • Special gear/trinket/enchants/consumables support - examples from shadowlands

SimC Client Addon

Depends on the base module being done, but the SimC Addon would also need updated/supported for Classic.

  • Addon loads gear in game via /simc properly

Class Modules

Each class module will need various work to make it usable for simming. Typically there is one or more devs per spec, but that isn't a hard requirement. Each class will need spell, tier set bonuses, APLs, and talent implementations.

  • Druid - N/A
  • Hunter - N/A
  • Mage - N/A
  • Paladin - N/A
  • Priest - @seanpeters86
  • Rogue - N/A
  • Shaman - N/A
  • Warlock - N/A
  • Warrior - N/A

Getting old code working

Note that if you want to get the Original TBC simc commit here working you just need to remove -mtune=pentium-m from the Makefile and then run ./simcraft file=profiles/dedmon max_time=300

@seanpeters86
Copy link
Member Author

seanpeters86 commented Mar 1, 2021

I made a new branch that just starts from the old tbc commit from a reference standpoint. This is just hard coded spell data with some basic sim support. You could build from this or fork off of the modern shadowlands code base. I added basic instructions for how to run that here: https://github.com/simulationcraft/simc/tree/old-tbc

I think it would probably be best to just create a branch off of shadowlands and delete everything except base module stuff and work up from there with hard coded data. That work is started here: https://github.com/simulationcraft/simc/tree/tbc

@lgkern lgkern pinned this issue Mar 3, 2021
@Undertoe
Copy link
Contributor

Undertoe commented Jun 7, 2021

@seanpeters86 has there been any update to this? I can start working on some of the class modules over the next few weeks if there has been any work on spell data. Immediate ones would be Ret paladin / prot paladin.

@seanpeters86
Copy link
Member Author

@seanpeters86 has there been any update to this? I can start working on some of the class modules over the next few weeks if there has been any work on spell data. Immediate ones would be Ret paladin / prot paladin.

No there has been no work on spell data. Would be faster to implement spells manually without spell data. On the tbc branch i was still working on removing all that I'm not sure if that was ever finished.

@seathasky
Copy link

Curious why QElive (https://questionablyepic.com/) has implemented SIMC for TBC healer builds, but cant find a Simc addon for TBC client. Does the SL Simc addon work in TBC?

@vituscze
Copy link
Contributor

vituscze commented Jun 9, 2021

The official simc addon did not receive any updates for TBC, so most likely no.

@Voulk
Copy link

Voulk commented Jun 9, 2021

I'm very sorry if I've mislead anyone. The TBC version of QE Live uses it's own addon to import gear, that is heavily based on SimC but is separate. You can grab it here: https://www.curseforge.com/wow/addons/qe-live-gear-importer-bc

@seathasky
Copy link

I'm very sorry if I've mislead anyone. The TBC version of QE Live uses it's own addon to import gear, that is heavily based on SimC but is separate. You can grab it here: https://www.curseforge.com/wow/addons/qe-live-gear-importer-bc

Ty Voulk! Thats great to know! I had no idea you guys had an importer! That's awesome news! Any chance you can add a link so people know the addon is available? Or is it already there and i missed it haha

@Voulk
Copy link

Voulk commented Jun 9, 2021

I'm very sorry if I've mislead anyone. The TBC version of QE Live uses it's own addon to import gear, that is heavily based on SimC but is separate. You can grab it here: https://www.curseforge.com/wow/addons/qe-live-gear-importer-bc

Ty Voulk! Thats great to know! I had no idea you guys had an importer! That's awesome news! Any chance you can add a link so people know the addon is available? Or is it already there and i missed it haha

I've just pushed a new build live that has a much clearer link to it. It was much too hard to find previously.

@tugaman
Copy link

tugaman commented Jun 21, 2021

is this project on hold, i would love Simc converted to TBC Classic

@seanpeters86
Copy link
Member Author

is this project on hold, i would love Simc converted to TBC Classic

Need more contributors to help out on the project. My free time is spent on 9.1 at the moment so do not have time to dedicate to this effort.

@tugaman
Copy link

tugaman commented Jun 22, 2021

is this project on hold, i would love Simc converted to TBC Classic

Need more contributors to help out on the project. My free time is spent on 9.1 at the moment so do not have time to dedicate to this effort.

i understand, its a pity tho, simc would be a great tool for TBC classic as well.

@Thaodan
Copy link

Thaodan commented Jul 2, 2021

I'm very sorry if I've mislead anyone. The TBC version of QE Live uses it's own addon to import gear, that is heavily based on SimC but is separate. You can grab it here: https://www.curseforge.com/wow/addons/qe-live-gear-importer-bc

Its a semi fork. Your code reads like s/simc/QE/g

@renanthera renanthera changed the title EPIC: Classic Vanilla/TBC Support EPIC: Classic Support Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants