Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show absorb details in report like other healing actions #6174

Open
seanpeters86 opened this issue Oct 4, 2021 · 0 comments
Open

Show absorb details in report like other healing actions #6174

seanpeters86 opened this issue Oct 4, 2021 · 0 comments

Comments

@seanpeters86
Copy link
Member

seanpeters86 commented Oct 4, 2021

Is your feature request related to a problem? Please describe.

When simming my character with enable_dps_healing=1 I would like the report to include details about absorb actions as well as heal actions. Currently absorb action stats do not display in the report output.

Not sure if this is a bug or not considering the table in the report does say absorbs as well:

healing

Describe the solution you'd like

Add absorb entries into the healing table in the generated report.

Describe alternatives you've considered

Could also have a separate absorb table, but it being tied to healing matches what is typical for in-game meters.

Additional context

Note below profile example required this PR to be merged to see the absorb: #6173

Sim profile that has an absorb:

priest="Base"
level=60
role=spell
position=back
talents=1111122
spec=shadow
covenant=night_fae
race=goblin
soulbind=dreamweaver:2,319217/283:9:1/107:9:1/319211/114:9:1/66:9:1/319216/319191/115:9:0/352779/69:9:0/352786

enable_dps_healing=1
default_actions=1

head=veil_of_the_banshee_queen,id=186325,ilevel=259,gem_id=173130/187320,bonus_id=6982
neck=interplanar_keystone,id=186379,ilevel=259,gem_id=173130
shoulders=frame_of_the_false_margrave,id=186324,ilevel=259,gem_id=187318
back=drape_of_twisted_loyalties,id=180123,ilevel=252
chest=sacrificers_sacramental_cassock,id=186282,ilevel=252,enchant=eternal_stats,gem_id=187319
wrists=desecrators_keening_wristwraps,id=186321,ilevel=259,gem_id=173130/187315,enchant=eternal_intellect
hands=grasps_of_the_clairvoyant_sage,id=186288,ilevel=252
waist=,id=186284,gem_id=187306,bonus_id=7188/6652/1485/6646
legs=muehzalas_hexthread_sarong,id=179351,bonus_id=7187/1540,ilevel=252
feet=sandals_of_sacred_symmetry,id=186354,ilevel=252
finger1=sworn_oath_of_the_nine,id=186290,ilevel=252,gem_id=173130,enchant=tenet_of_mastery
finger2=death_gods_signet,id=179355,bonus_id=7187/1540/6935,ilevel=252,gem_id=173130,enchant=tenet_of_mastery
trinket1=soulletting_ruby,id=178809,bonus_id=6536/1540/6646,ilevel=252
trinket2=forbidden_necromantic_tome,id=186421,ilevel=259
main_hand=maledict_opus,id=186406,ilevel=259,enchant=sinful_revelation

single_actor_batch=1
optimal_raid=1
desired_targets=1
iterations=10000

Example absorb actions from debug:

0.000 Player 'Base' gains Buff accretion (stacks=1) (value=1154.99275095168)

3.528 Player 'Base' tick amount for Action shadow_word_death_self_damage on Player 'Base': amount=3240 initial_amount=3240 base=3240.473047554532 bonus=0 s_mod=0 s_power=0 a_mod=0 a_power=0 mult=1, tick_mult=1
3.528 Damage to Base after all mitigation is 3132.270000
3.528 Player 'Base' Buff accretion absorbs 1154.99275095168 (remaining: 0)
3.528 Player 'Base' loses Buff accretion
3.528 Damage to Base after accretion is 1977.277249

From the example above you would expect 1154 healing to be attributed to the accretion action in the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant