Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Language support #2

Open
simurai opened this issue Jan 1, 2016 · 3 comments
Open

[Question] Language support #2

simurai opened this issue Jan 1, 2016 · 3 comments
Labels

Comments

@simurai
Copy link
Owner

simurai commented Jan 1, 2016

Question: What languages should the DuoTone themes support? Here a couple options:

  1. Only the ones that get bundled with Atom.
  2. No limits... the more the merrier!
  3. Bundles. Create different themes with different language support.. like a front-end optimized theme with HTML, JS, CSS etc. but not Java, C etc.
@simurai
Copy link
Owner Author

simurai commented Jan 1, 2016

The big question is: Is there a downside for 2nd? If there are like 100 extra language files? Apart from the extra work to keep maintaining them, maybe performance? But if it 100s of languages would slow down loading/rendering by like 2-3ms, still neglectable, I guess.

Maybe initially we can just do option 2 without much thinking and then at some point, reconsider the question.

simurai added a commit that referenced this issue Jan 2, 2016
Add more language support
@filipelinhares
Copy link
Contributor

I think Bundles is the best one, but we need to keep in mind it has differents languages which each front-end uses.

With the bundle way we need a good way to deal with some types of front-end.

  • The Rails guy. SASS, Slim or Haml.
  • The Node guy. JSX, Stylus, Jade.
  • All in one? (Slim, Jade, SCSS, Stylus)

What do you think about it?

@simurai
Copy link
Owner Author

simurai commented Jan 4, 2016

Ya, Bundles would be nice. But maybe hard to decide where to draw the line. And if there are multiple color variations, it would multiply the amount of themes needed.

Something I've been thinking lately:

  • Themes: Should only provide the colors, but no syntax highlighting logic.
  • Language packages: Should use the colors of a theme and do the syntax highlighting.

Then you would pick a theme because of a certain color scheme and install language packages because you work with certain file types/languages. And in a sense create your own "custom bundle".

If language packages shouldn't style anything, there could be 3 "packages":

  1. Themes -> define colors
  2. Languages -> define scopes
  3. Syntax -> define syntax (what scope should have what color)

But that needs some new convention.. so maybe something for Atom 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants