Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should extend pdf_sponge #9

Open
OdyX opened this issue Mar 13, 2023 · 2 comments
Open

Should extend pdf_sponge #9

OdyX opened this issue Mar 13, 2023 · 2 comments

Comments

@OdyX
Copy link

OdyX commented Mar 13, 2023

I suggest the implementation shall extend upon pdf_sponge instead of ModelePDFFactures; it could leave lots of margin-setting and positioning code away, instead of copy-pasting from pdf_crabe.
@OdyX
Copy link
Author

OdyX commented Mar 17, 2023

It seems I couldn't resist, and I have now proposed this to Dolibarr upstream for integration; Dolibarr/dolibarr#24252

@benvia
Copy link
Contributor

benvia commented Mar 17, 2023

I've see your PR in Dolibarr.
I will add QR-IBAN and reference to your PR in next few hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OdyX @benvia