Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with diacritics #3

Open
0xAli opened this issue Dec 16, 2014 · 3 comments
Open

Doesn't work with diacritics #3

0xAli opened this issue Dec 16, 2014 · 3 comments

Comments

@0xAli
Copy link

0xAli commented Dec 16, 2014

If a word contains diacritics (Tashkeel) it won't be handled properly.

PS: This gem is a life saver.

@sinantaifour
Copy link
Owner

Thanks @0xAli! I'd be happy to accept a pull request for this.

@mkdynamic
Copy link

Awesome gem, thanks!

Excuse my ignorance, but a couple questions on this issue:

  • How feasible would it be to support diacritics in this gem?
  • Without this, will the resulting string by illegible/wrong, or just sub-optimal/harder to read?

@0xAli
Copy link
Author

0xAli commented Jan 25, 2015

Hello!

  1. I plan to figure it out later i will (hopefully some day) pull it off, but my guess it's a matter of figuring out the values on a byte level and adding them in "charinfos"

  2. Without that support it will split the word https://i.imgur.com/fhdBuPH.png

I discovered this by accident while working on a project that had only one word with diacritics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants