From 75f97b108c239c5e33ef48db2d64e34dccd35a3f Mon Sep 17 00:00:00 2001 From: Jean-Pierre Portier Date: Tue, 24 Sep 2024 10:26:34 +0200 Subject: [PATCH] refactor (Voice): Remove unused event processing related to 'respond to incoming call' getting started --- .../com/mycompany/app/voice/Controller.java | 12 ----------- .../app/voice/ServerBusinessLogic.java | 20 ------------------- 2 files changed, 32 deletions(-) diff --git a/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/Controller.java b/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/Controller.java index 8150f29..7f97aab 100644 --- a/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/Controller.java +++ b/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/Controller.java @@ -2,11 +2,8 @@ import com.sinch.sdk.SinchClient; import com.sinch.sdk.domains.voice.WebHooksService; -import com.sinch.sdk.domains.voice.models.webhooks.AnsweredCallEvent; import com.sinch.sdk.domains.voice.models.webhooks.DisconnectCallEvent; import com.sinch.sdk.domains.voice.models.webhooks.IncomingCallEvent; -import com.sinch.sdk.domains.voice.models.webhooks.NotifyEvent; -import com.sinch.sdk.domains.voice.models.webhooks.PromptInputEvent; import java.util.Map; import java.util.logging.Logger; import org.springframework.beans.factory.annotation.Autowired; @@ -65,19 +62,10 @@ public ResponseEntity VoiceEvent( var response = switch (event) { case IncomingCallEvent e -> webhooksBusinessLogic.incoming(e); - case AnsweredCallEvent e -> webhooksBusinessLogic.answered(e); case DisconnectCallEvent e -> { webhooksBusinessLogic.disconnect(e); yield null; } - case PromptInputEvent e -> { - webhooksBusinessLogic.prompt(e); - yield null; - } - case NotifyEvent e -> { - webhooksBusinessLogic.notify(e); - yield null; - } default -> throw new IllegalStateException("Unexpected value: " + event); }; diff --git a/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/ServerBusinessLogic.java b/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/ServerBusinessLogic.java index e6cc4ca..b4eb7b9 100644 --- a/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/ServerBusinessLogic.java +++ b/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/ServerBusinessLogic.java @@ -3,11 +3,8 @@ import com.sinch.sdk.domains.voice.models.svaml.ActionHangUp; import com.sinch.sdk.domains.voice.models.svaml.InstructionSay; import com.sinch.sdk.domains.voice.models.svaml.SVAMLControl; -import com.sinch.sdk.domains.voice.models.webhooks.AnsweredCallEvent; import com.sinch.sdk.domains.voice.models.webhooks.DisconnectCallEvent; import com.sinch.sdk.domains.voice.models.webhooks.IncomingCallEvent; -import com.sinch.sdk.domains.voice.models.webhooks.NotifyEvent; -import com.sinch.sdk.domains.voice.models.webhooks.PromptInputEvent; import java.util.Collections; import java.util.logging.Logger; import org.springframework.stereotype.Component; @@ -31,25 +28,8 @@ public SVAMLControl incoming(IncomingCallEvent event) { .build(); } - public SVAMLControl answered(AnsweredCallEvent event) { - - LOGGER.info("Handle event: " + event); - - return SVAMLControl.builder().build(); - } - public void disconnect(DisconnectCallEvent event) { LOGGER.info("Handle event: " + event); } - - public void prompt(PromptInputEvent event) { - - LOGGER.info("Handle event: " + event); - } - - public void notify(NotifyEvent event) { - - LOGGER.info("Handle event: " + event); - } }