Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design idea #44

Closed
stevenvachon opened this issue Jun 23, 2017 · 8 comments
Closed

Design idea #44

stevenvachon opened this issue Jun 23, 2017 · 8 comments

Comments

@stevenvachon
Copy link

stevenvachon commented Jun 23, 2017

@sindresorhus
Copy link
Owner

I don't see the point in using the globs package. It does exactly the same as globby, just less and slower.

@sindresorhus sindresorhus changed the title design idea Design idea Jun 23, 2017
@stevenvachon
Copy link
Author

Its name makes sense for its specific purpose, and offloads that logic so that this package can focus on more than pluralizing.

@sindresorhus
Copy link
Owner

I don't see any benefit of offloading that. Naming is not really a good argument for doing it either.

@stevenvachon
Copy link
Author

Less code here and for us to test here.

@sindresorhus
Copy link
Owner

I don't modularize just for the sake of it. It should have a clear and large benefit. I see none here. The code here is already coded, tested and battle-proven.

@stevenvachon
Copy link
Author

stevenvachon commented Jun 23, 2017

Alright, then let's make the above changes in this repo, except for expandDirs.

@sindresorhus
Copy link
Owner

except for expandDirs.

I have a strong feeling that it will end up being implemented here, as your issue on the glob repo will either go unanswered or be declined, but sure, let's give it a try.

@sindresorhus
Copy link
Owner

Most of these optimizations should be implemented in fast-glob instead. Please open issues over there for the specific items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants