Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add files and stats to PrCommits stream #202

Open
dlouseiro opened this issue Jan 29, 2024 · 0 comments
Open

Re-add files and stats to PrCommits stream #202

dlouseiro opened this issue Jan 29, 2024 · 0 comments

Comments

@dlouseiro
Copy link

While testing out this tap, I noticed that, similarly to what happens in other variants of the tap-github out there, the Commits stream does not have the files and stats properties, as these ones can only be fetched commit by commit , but not when listing commits. These properties were once available in the Commits stream schema, but it became confusing for users that selected the stream to not see these data points materialised in their target (creating issues like this), hence they were removed by @dsprayberry in this PR.

In this same PR, the files and stats properties were also removed from the PrCommits stream (as they are also commit related streams). Although, unlike the Commits stream, these properties are available while listing commits for a PR, hence could be available in the PrCommits stream, even if they're not available in the Commits stream.

Functionally speaking, I'd also prefer that Github would keep their Commit related endpoints aligned and make files and stats available in both. Unfortunately this is not the case, but I still see the analytical value of having these fields available, even if only for commits that are linked to a Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant