-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TDL-24367] Fix streams implementation #64
Open
shantanu73
wants to merge
24
commits into
master
Choose a base branch
from
TDL-24367-fix-streams
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 937ec47 - Browse repository at this point
Copy the full SHA 937ec47View commit details
Commits on Oct 20, 2023
-
1) Changed LinkedIn API version to 202309. 2) Removed logic to add account parameter for streams with account filter search_account_param.
Configuration menu - View commit details
-
Copy full SHA for 84ce4dc - Browse repository at this point
Copy the full SHA 84ce4dcView commit details -
1) Added logic to iterate over each account and use modified url for campaigns, campaigngroups & creatives APIs. 2) Added X-Restli-Protocol-Version header & modified params fir campaigns & campaigngroups APIs. 3 ) Removed account_filter for campaigns & campaigngroups APIs. 4) Added a new parameter config for sync_endpoint method.
Configuration menu - View commit details
-
Copy full SHA for 661f1ee - Browse repository at this point
Copy the full SHA 661f1eeView commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for aa1ec85 - Browse repository at this point
Copy the full SHA aa1ec85View commit details
Commits on Nov 1, 2023
-
1) Added new schema for video_ads stream. 2) Modified enpoint and query params for video_ads stream. 3) Removed transform logic to flatten video_ads schema for change_audit_stamps fields.
Configuration menu - View commit details
-
Copy full SHA for 4c0c8bd - Browse repository at this point
Copy the full SHA 4c0c8bdView commit details
Commits on Nov 2, 2023
-
1) Modified schema for video_ads stream. 2) Added transform logic to add ad_context fields to root level.
Configuration menu - View commit details
-
Copy full SHA for 393dfb3 - Browse repository at this point
Copy the full SHA 393dfb3View commit details
Commits on Nov 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 13e9490 - Browse repository at this point
Copy the full SHA 13e9490View commit details
Commits on Nov 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ea6e61d - Browse repository at this point
Copy the full SHA ea6e61dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e19aa0e - Browse repository at this point
Copy the full SHA e19aa0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57276b1 - Browse repository at this point
Copy the full SHA 57276b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf70819 - Browse repository at this point
Copy the full SHA cf70819View commit details
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f57f63d - Browse repository at this point
Copy the full SHA f57f63dView commit details
Commits on Nov 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4397501 - Browse repository at this point
Copy the full SHA 4397501View commit details
Commits on Nov 23, 2023
-
1) Added get_config() method in LinkedInClient class to fetch config json. 2) Updated usage of get_config() method in discover & sync for tap.
Configuration menu - View commit details
-
Copy full SHA for 6bd4e7a - Browse repository at this point
Copy the full SHA 6bd4e7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for afb2d2f - Browse repository at this point
Copy the full SHA afb2d2fView commit details
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 59c5266 - Browse repository at this point
Copy the full SHA 59c5266View commit details -
Configuration menu - View commit details
-
Copy full SHA for a00f213 - Browse repository at this point
Copy the full SHA a00f213View commit details -
Removed get_config method and added config instance variable in Linke…
…dinClient class and updated its usage.
Configuration menu - View commit details
-
Copy full SHA for f3efe12 - Browse repository at this point
Copy the full SHA f3efe12View commit details -
Configuration menu - View commit details
-
Copy full SHA for d21583e - Browse repository at this point
Copy the full SHA d21583eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 754e11f - Browse repository at this point
Copy the full SHA 754e11fView commit details -
1) Fixed unit tests as per the new config param changes in LinkedinClient class. 2) Made changes in check_accounts() method as per config param changes. 3) Fixed unit tests as per changes in check_accounts() method.
Configuration menu - View commit details
-
Copy full SHA for cfee98e - Browse repository at this point
Copy the full SHA cfee98eView commit details -
1) Fixed dangerous default value pylint error in LinkedinClient class for config parameter. 2) Fixed unit tests as per above change.
Configuration menu - View commit details
-
Copy full SHA for afa8785 - Browse repository at this point
Copy the full SHA afa8785View commit details
Commits on Nov 29, 2023
-
[TDL-24282] Fix integration tests (#65)
* Changes: 1. Fixed video_ads metadata. 2. Fixed all fields & automatic fields tests. * Removed analytics streams from start_date, automatic_fields & bookmarks tests. * Fixed Parent child independent test for Ad analytics streams. * Removed unnecessary fields. * Removed beta fields from KNOWN_MISSING_FIELDS in All fields test for ad analytics streams. * Changes: 1) Added comment mentioning why the Ad Analytics streams were removed from testing. 2) Removed unneccary whitespace. * Fixed formatting.
Configuration menu - View commit details
-
Copy full SHA for 6d2cc56 - Browse repository at this point
Copy the full SHA 6d2cc56View commit details -
Updated scope information for video_ads stream in new API version upg…
…rade in README.md
Configuration menu - View commit details
-
Copy full SHA for 80bcf5e - Browse repository at this point
Copy the full SHA 80bcf5eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.