Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TDL-24367] Fix streams implementation #64

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    937ec47 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Changes:

    1) Changed LinkedIn API version to 202309.
    2) Removed logic to add account parameter for streams with account filter search_account_param.
    shantanu73 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    84ce4dc View commit details
    Browse the repository at this point in the history
  2. Changes:

    1) Added logic to iterate over each account and use modified url for campaigns, campaigngroups & creatives APIs.
    2) Added X-Restli-Protocol-Version header & modified params fir campaigns & campaigngroups APIs.
    3
    ) Removed account_filter for campaigns & campaigngroups APIs.
    4) Added a new parameter config for sync_endpoint method.
    shantanu73 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    661f1ee View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    aa1ec85 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Changes:

    1) Added new schema for video_ads stream.
    2) Modified enpoint and query params for video_ads stream.
    3) Removed transform logic to flatten video_ads schema for change_audit_stamps fields.
    shantanu73 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    4c0c8bd View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Changes:

    1) Modified schema for video_ads stream.
    2) Added transform logic to add ad_context fields to root level.
    shantanu73 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    393dfb3 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Configuration menu
    Copy the full SHA
    13e9490 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Fixed pylint issues.

    shantanu73 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ea6e61d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e19aa0e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57276b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cf70819 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    f57f63d View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    4397501 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Changes:

    1) Added get_config() method in LinkedInClient class to fetch config json.
    2) Updated usage of get_config() method in discover & sync for tap.
    shantanu73 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    6bd4e7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    afb2d2f View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    59c5266 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a00f213 View commit details
    Browse the repository at this point in the history
  3. Removed get_config method and added config instance variable in Linke…

    …dinClient class and updated its usage.
    shantanu73 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f3efe12 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d21583e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    754e11f View commit details
    Browse the repository at this point in the history
  6. Changes:

    1) Fixed unit tests as per the new config param changes in LinkedinClient class.
    2) Made changes in check_accounts() method as per config param changes.
    3) Fixed unit tests as per changes in check_accounts() method.
    shantanu73 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cfee98e View commit details
    Browse the repository at this point in the history
  7. Changes:

    1) Fixed dangerous default value pylint error in LinkedinClient class for config parameter.
    2) Fixed unit tests as per above change.
    shantanu73 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    afa8785 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. [TDL-24282] Fix integration tests (#65)

    * Changes:
    1. Fixed video_ads metadata.
    2. Fixed all fields & automatic fields tests.
    
    * Removed analytics streams from start_date, automatic_fields & bookmarks tests.
    
    * Fixed Parent child independent test for Ad analytics streams.
    
    * Removed unnecessary fields.
    
    * Removed beta fields from KNOWN_MISSING_FIELDS in All fields test for ad analytics streams.
    
    * Changes:
    1) Added comment mentioning why the Ad Analytics streams were removed from testing.
    2) Removed unneccary whitespace.
    
    * Fixed formatting.
    shantanu73 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6d2cc56 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80bcf5e View commit details
    Browse the repository at this point in the history