Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Linkedin API version from 202304 to 202403 #69

Merged
merged 12 commits into from
Apr 15, 2024
Merged

Upgrade Linkedin API version from 202304 to 202403 #69

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d747271
Update pagination logic for streams - accounts,campaign_groups,campai…
sgandhi1311 Apr 12, 2024
7bbcad0
update API endpoint
sgandhi1311 Apr 12, 2024
f7f988a
update the APi endpoints to include Adaccount in the url
sgandhi1311 Apr 13, 2024
faa6a39
remove unsupported params for Accounts stream
sgandhi1311 Apr 13, 2024
b99949c
updated query param format for accounts
sgandhi1311 Apr 13, 2024
b2aa449
handle pivot field for analytics API
sgandhi1311 Apr 13, 2024
d4e6eee
comment video_ads for the time being
sgandhi1311 Apr 13, 2024
93d6cf5
exclude missing fields from the all fields test
sgandhi1311 Apr 14, 2024
1ec1015
Upgrade api version 202403 video ads (#71)
somethingmorerelevant Apr 14, 2024
bcf7a97
unit test fix
sgandhi1311 Apr 14, 2024
9885719
update setup.py and changelog.md
sgandhi1311 Apr 15, 2024
ba25b15
fix review comments
sgandhi1311 Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# Changelog

## 2.3.0

### Features
- **API Updates**
- Bumped to API version `202304` ([#64](https://github.com/singer-io/tap-linkedin-ads/pull/69))
- Updated API endpoints for the following streams: `campaign_groups`, `campaigns`, `creatives`

- **Pagination Enhancements**
- Implemented cursor-based pagination for the following streams: `accounts`, `campaign_groups`, `campaigns`, `creatives`

- **API Query Param Adjustments**
- Removed unsupported `pivot` and `pivotValue` from `fields` query parameters in Analytics API requests
- Incorporated these values within the tap to ensure consistency with the previous tap version

- **Video Ads Stream**
- Added new fields ([#71](https://github.com/singer-io/tap-linkedin-ads/pull/71))
- Requires scope - `r_organization_social` to sync the records.
Copy link

@rdeshmukh15 rdeshmukh15 Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope requirements should be mentioned in README.md and not in CHANGELOG.md unless you have made changes on the tap side; specific to the scope.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


## 2.2.0
* Bump to API version `202304`

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

setup(name='tap-linkedin-ads',
version='2.2.0',
version='2.3.0',
description='Singer.io tap for extracting data from the LinkedIn Marketing Ads API API 2.0',
author='[email protected]',
classifiers=['Programming Language :: Python :: 3 :: Only'],
Expand Down
2 changes: 1 addition & 1 deletion tap_linkedin_ads/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
BASE_URL = 'https://api.linkedin.com/rest'
LINKEDIN_TOKEN_URI = 'https://www.linkedin.com/oauth/v2/accessToken'
INTROSPECTION_URI = 'https://www.linkedin.com/oauth/v2/introspectToken'
LINKEDIN_VERSION = '202304'
LINKEDIN_VERSION = '202403'

# set default timeout of 300 seconds
REQUEST_TIMEOUT = 300
Expand Down
180 changes: 180 additions & 0 deletions tap_linkedin_ads/schemas/video_ads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,186 @@
"string"
]
},
"lifecycle_state": {
"type": [
"null",
"string"
]
},
"visibility": {
"type": [
"null",
"string"
]
},
"published_at": {
"type": [
"null",
"string"
],
"format": "date-time"
},
"author": {
"type": [
"null",
"string"
]
},
"content_call_to_action_label": {
"type": [
"null",
"string"
]
},
"distribution": {
"type": [
"null",
"object"
],
"additionalProperties": false,
"properties": {
"feed_distribution": {
"type": [
"null",
"string"
]
},
"third_party_distribution_channels": {
"type": [
"null",
"array"
],
"items": {
"type": [
"null",
"string"
]
}
}
}
},
"content": {
"type": [
"null",
"object"
],
"additionalProperties": false,
"properties": {
"media": {
"type": [
"null",
"object"
],
"additionalProperties": false,
"properties": {
"title": {
"type": [
"null",
"string"
]
},
"id": {
"type": [
"null",
"string"
]
}
}
}
}
},
"content_landing_page": {
"type": [
"null",
"string"
]
},
"lifecycle_state_info": {
"type": [
"null",
"object"
],
"additionalProperties": false,
"properties": {
"is_edited_by_author": {
"type": [
"null",
"boolean"
]
}
}
},
"is_reshare_disabled_by_author": {
"type": [
"null",
"boolean"
]
},
"created_at": {
"type": [
"null",
"string"
],
"format": "date-time"
},
"last_modified_at": {
"type": [
"null",
"string"
],
"format": "date-time"
},
"id": {
"type": [
"null",
"string"
]
},
"commentary": {
"type": [
"null",
"string"
]
},
"ad_context": {
"type": [
"null",
"object"
],
"additionalProperties": false,
"properties": {
"dsc_status": {
"type": [
"null",
"string"
]
},
"dsc_name": {
"type": [
"null",
"string"
]
},
"dsc_ad_type": {
"type": [
"null",
"string"
]
},
"is_dsc": {
"type": [
"null",
"boolean"
]
},
"dsc_ad_account": {
"type": [
"null",
"string"
]
}
}
},
"account_id": {
"type": [
"null",
Expand Down
Loading