Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove special type handling in QueryCondition parser required for Python 3.7 #2185

Closed
nguyenv opened this issue Mar 1, 2024 · 1 comment
Assignees

Comments

@nguyenv
Copy link
Member

nguyenv commented Mar 1, 2024

https://github.com/single-cell-data/TileDB-SOMA/blob/main/apis/python/src/tiledbsoma/_query_condition.py#L374-L379

The Python AST module had a significant refactoring between 3.7 and 3.8 which in our code required special handling like in the example above. In 3.7, ast.Num, ast.Str, and ast.Bytes nodes needed to be handled separately. As of 3.8, that was deprecated and are now handled as ast.Constant or ast.NameConstant.

@nguyenv nguyenv changed the title Remove special type handling in QueryCondition parser required for Python 3.7 [python] Remove special type handling in QueryCondition parser required for Python 3.7 Mar 1, 2024
@nguyenv nguyenv changed the title [python] Remove special type handling in QueryCondition parser required for Python 3.7 [python] Remove special type handling in QueryCondition parser required for Python 3.7 Mar 1, 2024
@johnkerl
Copy link
Member

johnkerl commented Mar 1, 2024

Related to #2181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants