Fix column modifying on columnstore tables #88
Conversation
| if (version_compare(Application::VERSION, '10.0', '<')) { | ||
| throw new LogicException('This database driver does not support modifying columns on Laravel < 10.0.'); |
There was a problem hiding this comment.
What is the reason, why this is not supported for older versions of Laravel?
There was a problem hiding this comment.
Older Laravel versions don't support native column modifying, you may check:
- [10.x] Add support for native column modifying laravel/framework#45487
- [11.x] Remove Doctrine DBAL laravel/framework#48864
Laravel was using doctrine/dbal before this version and I'm quit sure that it is going to be a problem for your package as Doctrine DBAL doesn't support Singlestore. But you may add tests to see if it fallbacks to MySQL correctly or not.
There was a problem hiding this comment.
in the latest commit 9777d8a I removed this and added test to see if it works with lower Laravel version + Doctrine DBAL
There was a problem hiding this comment.
OK the tests shows that we can't use doctrine:
SQLSTATE[HY000]: General error: 1706 Feature 'ALTER TABLE CHANGE to modify column type' is not supported by SingleStore. Use MODIFY to change a column's type. (Connection: mysql, SQL: ALTER TABLE test CHANGE data data TEXT CHARACTER SET utf8mb4 DEFAULT NULL COLLATE
utf8mb4_unicode_ci)
|
It looks like |
|
@AdalbertMemSQL yeah I fixed that function on Laravel 10.30, it was using Doctrine DBAL before that. We can limit that assertion to latest version maybe? |
|
Yep, that sounds like a good solution |
Fixes #39
Add support for modifying columns on
Note 1: On Laravel 10.x, You have to call
Schema::useNativeSchemaOperationsIfPossible()method within thebootmethod of yourApp\Providers\AppServiceProviderclass. Not needed on Laravel 11.xNote 2: I'm not sure how Singlestore handles indexes and foreign keys of the column being modified, couldn't find anything related on the docs.