Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/CLI separation: snet identity create #32

Open
Necr0x0Der opened this issue May 15, 2024 · 2 comments
Open

SDK/CLI separation: snet identity create #32

Necr0x0Der opened this issue May 15, 2024 · 2 comments

Comments

@Necr0x0Der
Copy link

It's ok from SDK user perspective that CLI is installed together with SDK (although it can still be improved from the design perspective), but the necessity to run snet in command line is not good. In particular, to start using SDK, snet identity create is required.

How to reproduce:

  • create a fresh environment (without .snet in the home directory)
  • pip install snet.sdk
  • run test_sdk_client.py

SDK should not require running CLI manually and should not depend on its config since snet_sdk = sdk.SnetSDK(config) accepts config, which can contain anything needed (rather CLI should rely on sdk.SnetSDK)

@PAY2109
Copy link
Collaborator

PAY2109 commented Jun 21, 2024

Dear @Necr0x0Der,
Thank you for reporting this issue. We appreciate your feedback and apologize for any inconvenience caused. After thorough investigation, we have resolved this issue in the v3.3.0 of our app.
SDK now creates identity automatically.
Please update to the most recent release, and if you encounter any further problems, feel free to reopen this issue or create a new one.
Best regards, Paul, SingularityNET

@PAY2109 PAY2109 closed this as completed Jun 21, 2024
@PAY2109 PAY2109 reopened this Jun 25, 2024
@Necr0x0Der
Copy link
Author

Now, it works without explicit snet identity create, which is good. However, it creates config with identity.test, default endpoints, session on sepolia network. They seem to be ignored, so this is more or less ok, but they save my private key in config, which is not nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants