Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heplify does not capture RTCP packets when rtcp-mux is in use #226

Open
hamptonng opened this issue Apr 7, 2022 · 5 comments
Open

Heplify does not capture RTCP packets when rtcp-mux is in use #226

hamptonng opened this issue Apr 7, 2022 · 5 comments
Assignees

Comments

@hamptonng
Copy link

hamptonng commented Apr 7, 2022

We have two FreeSWITCH instances with a call between them (a load testing scenario), and they default to using rtcp-mux (RFC 5761).

In this case, heplify does not pass the RTCP packets for that call to the heplify server so no QoS information is recorded.

@hamptonng hamptonng changed the title Heplify does not capture RTCP packets when rtp-mux is in use Heplify does not capture RTCP packets when rtcp-mux is in use Apr 7, 2022
@lmangani
Copy link
Member

lmangani commented Apr 7, 2022

Thanks for the report @hamptonng
Please attach some examples or PCAP for the missed packets if you'd like this to be looked into

@hamptonng
Copy link
Author

ldtcall.zip

Thanks for the fast response - pcap attached.

@hamptonng
Copy link
Author

I believe a simple fix is to remove the odd port number check in decoder.go prior to correlateRTCP. Under rtcp-mux RTCP is likely to be on an even port number.

@kYroL01
Copy link
Contributor

kYroL01 commented Sep 30, 2022

@hamptonng Can you please attach your test pcap ? Unfortunately I don't see it here.
In this case we will recheck your PR and test with the pcap, so we can merge or adjust.
Thank you!

@hamptonng
Copy link
Author

hamptonng commented Sep 30, 2022

The pcap is in the zip file attached to the comment above on 7th April (ldtcall.zip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants