Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in G722Codec.cs when called with odd number of shorts #860

Open
ispysoftware opened this issue Oct 27, 2022 · 2 comments
Open

Crash in G722Codec.cs when called with odd number of shorts #860

ispysoftware opened this issue Oct 27, 2022 · 2 comments
Labels
bug codec

Comments

@ispysoftware
Copy link
Contributor

Need some check in G722Codec.cs Encoder as crash at line 417

state.QmfSignalHistory[23] = inputBuffer[j++];

if inputbuffer has odd length.
@sipsorcery
Copy link
Member

PR's welcome. The g729 codec was a copy paste from another open source implentation.

@ElDuderinoBerlin
Copy link

Have had the same bug. The C# code is a port from old C code orginally. So it's an very old bug in the original source code.
Sadly i don't know how to fix it.

@sipsorcery sipsorcery reopened this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug codec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sipsorcery @ispysoftware @ElDuderinoBerlin