Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embroider support #73

Open
steveszc opened this issue Apr 2, 2021 · 1 comment
Open

Embroider support #73

steveszc opened this issue Apr 2, 2021 · 1 comment

Comments

@steveszc
Copy link

steveszc commented Apr 2, 2021

This addon won't work in an app built with Embroider because it uses the postprocessTree hook for type=all, which is not supported in Embroider.

Some other addon's with this same issue:
DockYard/ember-service-worker#187
ef4/prember#59

@sir-dunxalot
Copy link
Owner

Hi @steveszc. Thanks for opening this issue. Unfortunately, I know nothing about Embroider and don't use Ember these days. I'll accept a PR that makes these changes if it doesn't break compatibility with non-Embroider apps. However, it's not likely I will make this change myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants