From 22ef36dc1fe1896cce005ab3171c3dd60206f5f1 Mon Sep 17 00:00:00 2001 From: sirEven <sir_even@icloud.com> Date: Fri, 4 Oct 2024 01:47:47 +0200 Subject: [PATCH] Remove TODOS. --- locast/candle_fetcher/dydx/api_fetcher/dydx_v3_fetcher.py | 3 --- locast/candle_fetcher/dydx/api_fetcher/dydx_v4_fetcher.py | 3 --- 2 files changed, 6 deletions(-) diff --git a/locast/candle_fetcher/dydx/api_fetcher/dydx_v3_fetcher.py b/locast/candle_fetcher/dydx/api_fetcher/dydx_v3_fetcher.py index 7fdc863..81fde75 100644 --- a/locast/candle_fetcher/dydx/api_fetcher/dydx_v3_fetcher.py +++ b/locast/candle_fetcher/dydx/api_fetcher/dydx_v3_fetcher.py @@ -16,9 +16,6 @@ from locast.candle_fetcher.dydx.api_fetcher.dydx_fetcher import DydxFetcher from locast.candle_fetcher.exceptions import APIException - -# TODO: Sort out Exception handling - maybe here an APIException might be fine - but it only should be raised when something goes wrong api wise - NOT when integrity errors or empty lists come back. -# OR no exception at all?? class DydxV3Fetcher(DydxFetcher): def __init__(self, client: Client, rate_throttle_sec: float = 0.4) -> None: self._exchange = Exchange.DYDX diff --git a/locast/candle_fetcher/dydx/api_fetcher/dydx_v4_fetcher.py b/locast/candle_fetcher/dydx/api_fetcher/dydx_v4_fetcher.py index 2c514dd..8fc043a 100644 --- a/locast/candle_fetcher/dydx/api_fetcher/dydx_v4_fetcher.py +++ b/locast/candle_fetcher/dydx/api_fetcher/dydx_v4_fetcher.py @@ -17,9 +17,6 @@ from locast.candle_fetcher.dydx.api_fetcher.dydx_fetcher import DydxFetcher from locast.candle_fetcher.exceptions import APIException - -# TODO: Sort out Exception handling - maybe here an APIException might be fine - but it only should be raised when something goes wrong api wise - NOT when integrity errors or empty lists come back. -# OR no exception at all?? class DydxV4Fetcher(DydxFetcher): def __init__( self,