Revert "chore: New task execution task id test (dapr#1352)" (dapr#1389)

This reverts commit 949584f.

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: sirivarma <[email protected]>

Author: javier-aliaga

daprdocs/content/en/java-sdk-docs/java-workflow/java-workflow-howto.md

@@ -6,7 +6,7 @@ weight: 20000
 description: How to get up and running with workflows using the Dapr Java SDK
 ---
 
-Let's create a Dapr workflow and invoke it using the console. With the [provided workflow example](https://github.com/dapr/java-sdk/tree/master/examples/src/main/java/io/dapr/examples/workflows), you will:
+Let’s create a Dapr workflow and invoke it using the console. With the [provided workflow example](https://github.com/dapr/java-sdk/tree/master/examples/src/main/java/io/dapr/examples/workflows), you will:
 
 - Execute the workflow instance using the [Java workflow worker](https://github.com/dapr/java-sdk/blob/master/examples/src/main/java/io/dapr/examples/workflows/DemoWorkflowWorker.java)
 - Utilize the Java workflow client and API calls to [start and terminate workflow instances](https://github.com/dapr/java-sdk/blob/master/examples/src/main/java/io/dapr/examples/workflows/DemoWorkflowClient.java)
@@ -85,10 +85,11 @@ You're up and running! Both Dapr and your app logs will appear here.
 == APP == INFO: Durable Task worker is connecting to sidecar at 127.0.0.1:50001.
 ```
 
-## Run the `DemoWorkflowClient`
+## Run the `DemoWorkflowClient
 
 The `DemoWorkflowClient` starts instances of workflows that have been registered with Dapr.
 
+
 ```java
 public class DemoWorkflowClient {
 
@@ -245,40 +246,4 @@ Exiting DemoWorkflowClient.
 
 ## Next steps
 - [Learn more about Dapr workflow]({{< ref workflow-overview.md >}})
-- [Workflow API reference]({{< ref workflow_api.md >}})
-
-## Advanced features
-
-### Task Execution Keys
-
-Task execution keys are unique identifiers generated by the durabletask-java library. They are stored in the `WorkflowActivityContext` and can be used to track and manage the execution of workflow activities. They are particularly useful for:
-
-1. **Idempotency**: Ensuring activities are not executed multiple times for the same task
-2. **State Management**: Tracking the state of activity execution
-3. **Error Handling**: Managing retries and failures in a controlled manner
-
-Here's an example of how to use task execution keys in your workflow activities:
-
-```java
-public class TaskExecutionKeyActivity implements WorkflowActivity {
-  @Override
-  public Object run(WorkflowActivityContext ctx) {
-    // Get the task execution key for this activity
-    String taskExecutionKey = ctx.getTaskExecutionKey();
-    
-    // Use the key to implement idempotency or state management
-    // For example, check if this task has already been executed
-    if (isTaskAlreadyExecuted(taskExecutionKey)) {
-      return getPreviousResult(taskExecutionKey);
-    }
-    
-    // Execute the activity logic
-    Object result = executeActivityLogic();
-    
-    // Store the result with the task execution key
-    storeResult(taskExecutionKey, result);
-    
-    return result;
-  }
-}
-```
+- [Workflow API reference]({{< ref workflow_api.md >}})

sdk-tests/src/test/java/io/dapr/it/testcontainers/DaprWorkflowsIT.java

@@ -15,7 +15,6 @@
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
-
 import io.dapr.testcontainers.Component;
 import io.dapr.testcontainers.DaprContainer;
 import io.dapr.testcontainers.DaprLogLevel;
@@ -41,7 +40,6 @@
 import java.util.Map;
 
 import static io.dapr.it.testcontainers.ContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
-import static org.junit.Assert.assertTrue;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
@@ -119,29 +117,6 @@ public void testWorkflows() throws Exception {
     assertEquals(instanceId, workflowOutput.getWorkflowId());
   }
 
-  @Test
-  public void testExecutionKeyWorkflows() throws Exception {
-    TestWorkflowPayload payload = new TestWorkflowPayload(new ArrayList<>());
-    String instanceId = workflowClient.scheduleNewWorkflow(TestExecutionKeysWorkflow.class, payload);
-
-    workflowClient.waitForInstanceStart(instanceId, Duration.ofSeconds(100), false);
-    
-    Duration timeout = Duration.ofSeconds(1000);
-    WorkflowInstanceStatus workflowStatus = workflowClient.waitForInstanceCompletion(instanceId, timeout, true);
-
-    assertNotNull(workflowStatus);
-
-    TestWorkflowPayload workflowOutput = deserialize(workflowStatus.getSerializedOutput());
-
-    assertEquals(1, workflowOutput.getPayloads().size());
-    assertEquals("Execution key found", workflowOutput.getPayloads().get(0));
-    
-    String executionKey = workflowOutput.getWorkflowId() +"-"+"io.dapr.it.testcontainers.TaskExecutionKeyActivity";
-    assertTrue(KeyStore.getInstance().getKey(executionKey));
-    
-    assertEquals(instanceId, workflowOutput.getWorkflowId());
-  }
-
   private TestWorkflowPayload deserialize(String value) throws JsonProcessingException {
     return OBJECT_MAPPER.readValue(value, TestWorkflowPayload.class);
   }

sdk-tests/src/test/java/io/dapr/it/testcontainers/KeyStore.java

@@ -56,12 +56,9 @@ public WorkflowRuntimeBuilder workflowRuntimeBuilder(
     WorkflowRuntimeBuilder builder = new WorkflowRuntimeBuilder(new Properties(overrides));
 
     builder.registerWorkflow(TestWorkflow.class);
-    builder.registerWorkflow(TestExecutionKeysWorkflow.class);
     builder.registerActivity(FirstActivity.class);
     builder.registerActivity(SecondActivity.class);
-    builder.registerActivity(TaskExecutionKeyActivity.class);
-    
-    
+
     return builder;
   }
 }

sdk-tests/src/test/java/io/dapr/it/testcontainers/TaskExecutionKeyActivity.java

@@ -17,8 +17,6 @@ public interface WorkflowActivityContext {
 
   String getName();
 
-  String getTaskExecutionKey();
-
   <T> T getInput(Class<T> targetType);
 
 }

sdk-tests/src/test/java/io/dapr/it/testcontainers/TestDaprWorkflowsConfiguration.java

@@ -56,9 +56,4 @@ public String getName() {
   public <T> T getInput(Class<T> targetType) {
     return this.innerContext.getInput(targetType);
   }
-
-  @Override
-  public String getTaskExecutionKey() {
-    return this.innerContext.getTaskExecutionKey();
-  }
 }

sdk-tests/src/test/java/io/dapr/it/testcontainers/TestExecutionKeysWorkflow.java

@@ -16,7 +16,7 @@ public static class TestActivity implements WorkflowActivity {
     @Override
     public Object run(WorkflowActivityContext ctx) {
       String activityContextName = ctx.getName();
-      return ctx.getInput(String.class) + " world! from " + activityContextName + " with task execution key " + ctx.getTaskExecutionKey();
+      return ctx.getInput(String.class) + " world! from " + activityContextName;
     }
   }
 
@@ -37,11 +37,10 @@ public void createWithClass() {
 
     when(mockContext.getInput(String.class)).thenReturn("Hello");
     when(mockContext.getName()).thenReturn("TestActivityContext");
-    when(mockContext.getTaskExecutionKey()).thenReturn("123");
 
     Object result = wrapper.create().run(mockContext);
 
     verify(mockContext, times(1)).getInput(String.class);
-    assertEquals("Hello world! from TestActivityContext with task execution key 123", result);
+    assertEquals("Hello world! from TestActivityContext", result);
   }
 }