Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addCommand #53

Open
timwilky opened this issue Mar 26, 2014 · 1 comment
Open

addCommand #53

timwilky opened this issue Mar 26, 2014 · 1 comment

Comments

@timwilky
Copy link

addCommand does not return a status, therefore there is no indication that use that would exceed the array bounds of the m_commands array has been dropped. Therefore a default maximum of only 8 commands can exist

When the dropped command is then requested, the failure page is then delivered.

quick fix to immediate issue, make the array size user defined in the header to stop dropped commands

@unwiredben
Copy link
Collaborator

open to pull requests on this one. I like the idea of making the array size a #define since that makes it more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants