Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airrecord::Client's connection has no adapter #44

Open
chrisfrank opened this issue Nov 13, 2018 · 1 comment
Open

Airrecord::Client's connection has no adapter #44

chrisfrank opened this issue Nov 13, 2018 · 1 comment
Labels
1.1 bug

Comments

@chrisfrank
Copy link
Collaborator

chrisfrank commented Nov 13, 2018 •
edited
Loading

It looks like we're no longer setting conn.adapter = :net_http_persistent in Airrecord::Client. This doesn't trigger any test failures, but it does make Airrecord unable to make real network requests!

I propose writing some tests for Airrecord::Client, including explicitly testing that its Faraday connection is set.
@sirupsen
Copy link
Owner

I botched that in resolving the merge conflict for 467aebd, fixed in dcb506d.

We don't need to block 1.0 on this test, but agree, we should have one 👍

@sirupsen sirupsen added 1.1 and removed 1.0 labels Nov 14, 2018
@chrisfrank chrisfrank mentioned this issue Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.1 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle network requests in Airrecord::Client sirupsen/airrecord
2 participants
@sirupsen @chrisfrank