FEATURE: Use registered secondary media selection screen #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: sitegeist#50 With this change any registered MediaSelectionScreen secondary editor is used instead of the fixed dependency on the media browser. This way the Flowpack.Media.UI will be used when it is installed a project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #50
With this change any registered MediaSelectionScreen secondary editor is used instead of the fixed dependency on the media browser. This way the Flowpack.Media.UI will be used when it is installed a project.
This also means that no event handler is required anymore for selection as the component provides this already. In the future also constraints would be supported this way as they can be passed to the component.
The only "hotfix" is that the MediaBrowser still needs some custom styling to remove the padding like before.
After this change the 2 editors look like this:
MediaBrowser:
Media.UI: