Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure position sorting reversed? #152

Open
bastianschwarz opened this issue Jun 21, 2021 · 3 comments
Open

Structure position sorting reversed? #152

bastianschwarz opened this issue Jun 21, 2021 · 3 comments

Comments

@bastianschwarz
Copy link

This is more of a question than a real issue but the sorting of the structures reversed. I think this happend when the useCase feature was released because I know it worked previously.

I configured custom structures like:

      structure:
        base:
          position: -1000
          match: Presentation\.Templates
          label: Templates
          icon: icon-file
          color: '#FFF'
        atoms:
          position: 200
          match: Presentation\.Atoms
          label: Atoms
          icon: icon-gear
          color: '#4DBCE9'
        molecules:
          position: 300
          match: Presentation\.Molecules
          label: Molecules
          icon: icon-gears
          color: '#26ADE4'

And I know the Templates were first since this is what our customers look at so I pushed them to the start.

This raises 2 questions:

  • Was this "by choice"?
  • If so, should this be at least documented in the readme? Currently the position has no own explanation

Obviously this has no priority at all since I can just change the values but it's something I noticed just now.

@jonnitto
Copy link
Contributor

jonnitto commented Dec 9, 2021

I can confirm this bug. @mficzel, was this on purpose?

@mficzel
Copy link
Member

mficzel commented Dec 9, 2021

Nope not on purpose ... do i understand correctly that this is non urgent?

@bastianschwarz
Copy link
Author

Yes, no urgency at all. We just reversed it in our config. It's more a convenience for our customers to have the example pages up top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants