From 185630431bec4e7d4b097b873b3369a181ae5608 Mon Sep 17 00:00:00 2001 From: Peter Hedenskog Date: Sun, 16 Jul 2023 17:54:37 +0200 Subject: [PATCH] more Safari fixes (#1951) * The GitHub instance is super slow, disable videos --- .github/workflows/safari.yml | 22 +++++++++++----------- test/data/navigationscript/multiMac.cjs | 4 ++++ 2 files changed, 15 insertions(+), 11 deletions(-) create mode 100644 test/data/navigationscript/multiMac.cjs diff --git a/.github/workflows/safari.yml b/.github/workflows/safari.yml index cf9646997..eec731ce7 100644 --- a/.github/workflows/safari.yml +++ b/.github/workflows/safari.yml @@ -42,15 +42,15 @@ jobs: run: | IPHONE14=$(xcrun xctrace list devices 2>&1 | grep -m 1 "iPhone 14 Simulator" | awk -F'[()]' '{print $4}') xcrun simctl boot $IPHONE14 - - name: Start local HTTP server - run: (npm run start-server&) + #- name: Start local HTTP server + # run: (npm run start-server&) - name: Test Safari without video - run: ./bin/browsertime.js -b safari -n 1 http://127.0.0.1:3000/simple/ - #- name: Test Safari iOS simulator - # run: | - # IPHONE14=$(xcrun xctrace list devices 2>&1 | grep -m 1 "iPhone 14 Simulator" | awk -F'[()]' '{print $4}') - # ./bin/browsertime.js -b safari -n 1 --safari.useSimulator --video --visualMetrics --safari.deviceUDID $IPHONE14 https://www.sitespeed.io/ - - name: Test Safari with video and Visual Metrics - run: ./bin/browsertime.js -b safari -n 1 --viewPort 800x600 --video --visualMetrics http://127.0.0.1:3000/simple/ - - name: Test Safari with video and Visual Metrics for multi pages - run: ./bin/browsertime.js -b safari -n 1 --viewPort 800x600 --video --visualMetrics test/data/navigationscript/multi.cjs \ No newline at end of file + run: ./bin/browsertime.js -b safari -n 1 https://www.sitespeed.io/ + - name: Test Safari iOS simulator + run: | + IPHONE14=$(xcrun xctrace list devices 2>&1 | grep -m 1 "iPhone 14 Simulator" | awk -F'[()]' '{print $4}') + ./bin/browsertime.js -b safari -n 1 --safari.useSimulator --video --visualMetrics --safari.deviceUDID $IPHONE14 https://www.sitespeed.io/ + #- name: Test Safari with video and Visual Metrics + # run: ./bin/browsertime.js -b safari -n 1 --viewPort 800x600 --video --visualMetrics https://www.sitespeed.io/ + #- name: Test Safari with video and Visual Metrics for multi pages + # run: ./bin/browsertime.js -b safari -n 1 --viewPort 800x600 --video --visualMetrics test/data/navigationscript/multiMac.cjs \ No newline at end of file diff --git a/test/data/navigationscript/multiMac.cjs b/test/data/navigationscript/multiMac.cjs new file mode 100644 index 000000000..e5a5d8449 --- /dev/null +++ b/test/data/navigationscript/multiMac.cjs @@ -0,0 +1,4 @@ +module.exports = async function (context, commands) { + await commands.measure.start('https://www.sitespeed.io'); + return commands.measure.start('https://www.sitespeed.io/documentation/'); +};