Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: replace ENV['TEST_ENV_NUMBER'] #102

Open
wscourge opened this issue Jan 5, 2023 · 0 comments
Open

Improvement: replace ENV['TEST_ENV_NUMBER'] #102

wscourge opened this issue Jan 5, 2023 · 0 comments

Comments

@wscourge
Copy link

wscourge commented Jan 5, 2023

Hey, here's a nice thing I found in other open-sourced gem knapsack

def ci_node_index
  gitlab_ci_node_index || ENV['CI_NODE_INDEX'] || ENV['CIRCLE_NODE_INDEX'] || semaphore_job_index || semaphore_current_thread || ENV['BUILDKITE_PARALLEL_JOB'] || snap_ci_worker_index || ENV['BITBUCKET_PARALLEL_STEP'] || 0
end

Assuming that no1 actually reads XML junit and its usage is for CI to render nice results in the UI, I suggest replacing your custom TEST_ENV_NUMBER variable with this approach.

Cheers, and keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant