Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Step 5 switch not work #36

Open
sovetski opened this issue Jun 11, 2023 · 4 comments
Open

[Bug] Step 5 switch not work #36

sovetski opened this issue Jun 11, 2023 · 4 comments
Labels
bug Something isn't working needs engineering Requires engineering-specific changes only.

Comments

@sovetski
Copy link

Summary

The file "/.github/workflows/4-add-branch-protections.yml" is not working, the step switching part is commented

image

How to reproduce

Just create a branch protection and nothing will happen to switching automatically to the next step

@sovetski sovetski added the bug Something isn't working label Jun 11, 2023
@hectorsector hectorsector added the needs engineering Requires engineering-specific changes only. label Jun 12, 2023
@cuatrosr
Copy link

This is how i solved it:
Generate a PAT classic with repository public permissions, put it on GItHub Secrets and add it below checkout -> with: -> token: {{ PAT_SECRET }}. Also, uncomment all the lines of Update to step 5 and do a manual run of Step 4 workflow.

@gjuliao
Copy link

gjuliao commented Jan 10, 2024

Faced the same issue as @sovetski. On my side that part appears uncommented but still nothing happens passed that stage after protecting the branch.

@hectorsector
Copy link

Thanks for the report, @sovetski.

Although the course looks different today than when originally reported, we're still seeing almost 40% learner drop off at this step so I'm inclined to believe it can stand some improvement.

@hsnabszhdn
Copy link

hsnabszhdn commented Aug 17, 2024

Happened to me as well; although confusing, I feel like an idiot after knowing what happened!

In step 4, it says enable branch protection rule on main (again on main). How could I expect the main branch to be updated automatically after this rule? No matter how many times I refreshed, of course it wouldn't change.

The instruction says: "...go to the ci branch..." (which I had missed)

image

And of course, after switching to the ci branch, there it was: step 5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering-specific changes only.
Projects
None yet
Development

No branches or pull requests

5 participants