chore: Rename slinky=>connect #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
requested review from
aljo242,
technicallyty and
wesl-ee
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 56.69% 56.67% -0.02%
==========================================
Files 256 256
Lines 13406 13406
==========================================
- Hits 7600 7598 -2
- Misses 5079 5081 +2
Partials 727 727 ☔ View full report in Codecov by Sentry. |
aljo242
reviewed
Aug 14, 2024
| @@ -33,7 +33,7 @@ import ( | |||
| var ( | |||
| rootCmd = &cobra.Command{ | |||
| Use: "oracle", | |||
| Short: "Run the slinky oracle server.", | |||
| Short: "Run the connect oracle server.", | |||
There was a problem hiding this comment.
Can we rename this path to "connect" as well?
aljo242
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves publication of all docker images to connect naming. Duplicates the
slinky-sidecarimage into two images,connect-sidecaras well as the original image with a deprecation notice included.Renames the simapp to
connectd, and copies theslinkybinary toconnect.