-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor cleanup #764
chore: minor cleanup #764
Conversation
test failing is just a flaky test we will be fixing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 57.03% 57.01% -0.02%
==========================================
Files 208 208
Lines 11632 11625 -7
==========================================
- Hits 6634 6628 -6
+ Misses 4394 4393 -1
Partials 604 604 ☔ View full report in Codecov by Sentry. |
What's the process to get this merged? Anything I have to do? |
No, I was just waiting on us to make a release earlier next week before merging. I'll merge this |
ah okay, my bad. didnt see an update so was unsure |
this pr removes some
sdk.Context
usage as its not needed. It also preps migration for 52/v2happy to reduce scope. just saw some cleanup while reading the code