Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor cleanup #764

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Conversation

tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Sep 19, 2024

this pr removes some sdk.Context usage as its not needed. It also preps migration for 52/v2

happy to reduce scope. just saw some cleanup while reading the code

@aljo242
Copy link
Contributor

aljo242 commented Sep 19, 2024

test failing is just a flaky test we will be fixing

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.01%. Comparing base (0a2f3da) to head (e5e3b8a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/oracle/keeper/grpc_query.go 66.66% 1 Missing ⚠️
x/oracle/keeper/keeper.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   57.03%   57.01%   -0.02%     
==========================================
  Files         208      208              
  Lines       11632    11625       -7     
==========================================
- Hits         6634     6628       -6     
+ Misses       4394     4393       -1     
  Partials      604      604              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tac0turtle
Copy link
Contributor Author

What's the process to get this merged? Anything I have to do?

@aljo242
Copy link
Contributor

aljo242 commented Sep 23, 2024

What's the process to get this merged? Anything I have to do?

No, I was just waiting on us to make a release earlier next week before merging. I'll merge this

@tac0turtle
Copy link
Contributor Author

What's the process to get this merged? Anything I have to do?

No, I was just waiting on us to make a release earlier next week before merging. I'll merge this

ah okay, my bad. didnt see an update so was unsure

@aljo242 aljo242 merged commit b28f1f6 into skip-mev:main Sep 23, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants