Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic improvements: determineReward / claimReward / tokenClaims #62

Open
kangarang opened this issue Apr 19, 2018 · 2 comments
Open

Comments

@kangarang
Copy link
Collaborator

  1. determineReward: gets the number of tokens for the winning party of a challenge (Applicant or Challenger, not Voter)

How about challengeWinnerReward? (same implementation as the now deprecated #10)


  1. claimReward: only deals with Voter.

How about claimVoterReward? (same implementation as the now deprecated #10)


  1. tokenClaims: sounds like it would return true if a voter has claim to some tokens. however the opposite is true. (clearly i was confused in Semantic improvements #9)

How about voterClaimedReward?

@kangarang
Copy link
Collaborator Author

The variable reward can be renamed to be more specific to the challenge winner:

uint reward = determineReward(challengeID);

The variable reward can be renamed to be more specific to the voter reward pool:

https://github.com/skmgoldin/tcr/blob/master/contracts/Registry.sol#L251

This comment could be improved to be more specific to the total number of tokens that will be rewarded to the majority bloc of voters:

https://github.com/skmgoldin/tcr/blob/master/contracts/Registry.sol#L388

@kangarang
Copy link
Collaborator Author

kangarang commented May 16, 2018

related: Consensys/PLCRVoting#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant