__package_pip: Fall back to __object_id if the package name can't be deduced from --requirement #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t be deduced from --requirement
|
|
4nd3r
reviewed
May 2, 2022
| package manager. | ||
| Furthermore, if a URL does not start with ``[packagename]@``, the type will fall | ||
| back to assume the ``__object_id`` contains the package name what would be | ||
| installed by the given ``--requirement``. |
There was a problem hiding this comment.
let's move this section to requirement parameter section?
sideeffect42
commented
May 2, 2022
|
|
||
| def check_requirement(r): | ||
| try: | ||
| pkg_resources.require(requirement) |
There was a problem hiding this comment.
Note to self: incorrect variable name.
4nd3r
force-pushed
the
main
branch
3 times, most recently
from
88ec47e
to
5425f2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #45.
Please test.