Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query rusb for detach support #43

Merged
merged 1 commit into from
May 17, 2023

Conversation

felfert
Copy link
Collaborator

@felfert felfert commented May 16, 2023

Description

This PR provides a very minimal change for the condition of enabling the auto_detach_kernel feature.
Instead of enabling it on all unix platforms, it actually queries the relevant flag of libusb. rusb provides
a function
for that specifically.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Code Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have implemented respective test(s)
  • I have run lints and tests (cargo fmt && cargo clippy && cargo test) that prove my fix is effective or that my feature works

@skraus-dev PS: Now that CI/CD is working again and my solution to #22 (introducing the VHID driver) is here, I would LOVE to see a new release soon. (I already have an updated rpm spec file for fedora packaging and as soon as the next version is available, I can provide Fedora packages with preconfigured systemd service).

@skraus-dev
Copy link
Owner

skraus-dev commented May 17, 2023

Thx for the addition.

Yup, will draft a new release now.

UPDATE: Will start drafting the new release when the ubuntu apt mirror, used in the CI chain, is fixed. Currently its returning 503 for a few dependencies.

@skraus-dev skraus-dev merged commit 798bf01 into skraus-dev:master May 17, 2023
@felfert
Copy link
Collaborator Author

felfert commented May 17, 2023

Yup, will draft a new release now.

UPDATE: Will start drafting the new release when the ubuntu apt mirror, used in the CI chain, is fixed. Currently its returning 503 for a few dependencies.

Hmm. crates.io the (doc) build failed:
https://docs.rs/crate/cherryrgb/0.2.5/builds/817053

They use a nightly toolkit and maybe the build config there should be updated too (Adding --feadures uhid)

@felfert felfert deleted the query-rusb-support branch May 17, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants