-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc improvements of table report #1052
Comments
Also, the TableReport returns an error when the dataframe contains a list: import pandas as pd
from skrub import TableReport
TableReport(
pd.DataFrame(dict(a=[[1]]))
) Traceback
|
thanks for reporting it. it is because the unique value counts are stored in a dict and in this case the value is not hashable. I'll open a separate issue for that |
For the appearance, my vote goes to striped table, shadows on cards, no selected cell outline. If there's a poll somewhere I'm happy to share it there |
keeping track of a few things we discussed during and after euroscipy:
functionality
appearance
make tables not striped (alternating gray levels for rows), less contrast in gray levels, some styling of interactive elements?(we decided not to do it)borders instead of shadows around cards?(we decided not to do it)python interface / long-term
The text was updated successfully, but these errors were encountered: