Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] un-stale the package and give simple instructions for working install #1590

Open
veberi-alteo opened this issue Aug 9, 2024 · 6 comments
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@veberi-alteo
Copy link

Could somebody give a docker image, or detailes of package versions.
I tried multiple installations and most of the time had errors when running the tutorials.

As the library becomes stale it is more and more difficult to make the proper environment.

Please share detailes, thanks.

@ari99
Copy link

ari99 commented Aug 9, 2024

I'm starting to work on getting it running, this allowed me to get the tests passing (see my fork for a code change as well)


pip install poetry
poetry install
pip install numba
pip install cpflows

@veberi-alteo
Copy link
Author

Hi, thanks for the answer, do you use the latest available versions from the above list then?

@IlIlllIIllIIlll
Copy link

Try using an older version, build with these two files:

poetry.lock
pyproject.toml

pip install poetry
poetry install --all-extras

and build whl package

python -m build

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 25, 2024

We will hopefully "un-stale" the library over the next weeks
#1592

Help with this would be greatly appreciated!

If you would like to, you can get in touch on the sktime discord: https://discord.com/invite/54ACzaFsn7 - mention this when you give your intro on the intro channel.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Aug 25, 2024
@fkiraly fkiraly changed the title Most stable working version guide [ENH] un-stale the package and give simple instructions for working install Aug 25, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented Aug 30, 2024

@ari99, the changes in your fork look great, thanks a lot for your effort! Would you be willing to make pull requests out of them - optimally, split up in small, mergeable bits? That is, multiple pull request, each of which fixes one thing at a time?

From a maintenance perspective, we need to adopt a piecewise approach, and we need to ensure no currently running code is going to break.

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 30, 2024

Also apologies, we (the sktime maintainers) had not spotted your fork until now - the usual way to make your contributions seen easily is via pull requests, that's why I'm asking. That also allows you to get the contribution recognition you deserve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

No branches or pull requests

4 participants