Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] neural network libraries in thuml time-series-library #7243

Open
fkiraly opened this issue Oct 9, 2024 · 4 comments
Open

[ENH] neural network libraries in thuml time-series-library #7243

fkiraly opened this issue Oct 9, 2024 · 4 comments
Labels
enhancement Adding new functionality implementing algorithms Implementing algorithms, estimators, objects native to sktime interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Oct 9, 2024

I found this repository

https://github.com/thuml/Time-Series-Library

which implements a large number of state-of-art neural network models in torch, and seems to be updated regularly.

The repository is not a pypi package and relies on source install.

There is also a large PR that turns it into a package, but it seems stale or unreviewed:
thuml/Time-Series-Library#457

I wonder about the best way to integrate here. Nothing keeps us from copying layers and networks, but that is perhaps not the best way to proceed (and also not that nice towards the authors). But interfacing is not possible without proper package management, similar to the cure-lab problem.

From a tech perspective, a merge or some kind of connection with pytorch-forecasting could make sense, and then interfacing from sktime one layer higher. A connection which is not merge is turning pytorch-forecasting into a torch neural network and components indexer, using scikit-base, where components are not necessarily directly in the package.

FYI @XinyuWuu, the most active devs seem to be all from China, do you know them? I have also not reviewed the code in detail, e.g., intersections with pytorch-forecasting, or with neuralforecast.

@fkiraly fkiraly added implementing algorithms Implementing algorithms, estimators, objects native to sktime interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting enhancement Adding new functionality labels Oct 9, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Dec 12, 2024

FYI @thawn, would you like to help with integration with pytorch-forecasting?

  • we are now maintaining pytorch-forecasting
  • your pull request for proper package refactor looks like the direction we should go!

@thawn
Copy link

thawn commented Dec 12, 2024

@fkiraly I'd be happy to help. How would you like to proceed?

Are you by any chance at the Neurips 2024 in Vancouver? Then we could meet up ;-)

@fkiraly
Copy link
Collaborator Author

fkiraly commented Dec 13, 2024

Thanks for your reply, @thawn!

Are you by any chance at the Neurips 2024 in Vancouver?

No, not there. I am in the middle of a house move. Maybe someone else of @sktime/core-developers is?

How would you like to proceed?

Concretely, I would suggest getting in touch via discord (sktime server) https://discord.com/invite/54ACzaFsn7,
there is a channel for pytorch-forecasting there.

I think we need to have a 30-60min meeting with other deep learning focused developers to get to a clear architectural target state for pytorch-forecasting and a potential integration.

If you already have concrete ideas, that would be great to hear.

@agobbifbk will likely be driving the rework of ptf, he will also be at our meetup on Dec 20 (13 UTC). We could meet before quickly, and then with Andrea on Dec 20?

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jan 13, 2025

FYI @wuhaixu2016, @ZDandsomSP, @GuoKaku, @DigitalLifeYZQiu, @Musongwhk - discussions have evolved towards integrating the torch layers first, see sktime/pytorch-forecasting#1736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality implementing algorithms Implementing algorithms, estimators, objects native to sktime interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Development

No branches or pull requests

2 participants