Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tests for Cassandra 2.x and 3.x #45

Open
joseblas opened this issue Nov 8, 2016 · 4 comments
Open

Add regression tests for Cassandra 2.x and 3.x #45

joseblas opened this issue Nov 8, 2016 · 4 comments

Comments

@joseblas
Copy link
Contributor

joseblas commented Nov 8, 2016

CqlMigrate should work in both versions, and should be able to be tested within both versions.
Could be done by creating three modules: one for CqlMigrate and two other for tests. The latter should share the tests meanwhile is possible (no break changes)

@joseblas joseblas changed the title Add regrression Add regression tests for Cassandra 2.x and 3.x Nov 8, 2016
@joseblas
Copy link
Contributor Author

joseblas commented Nov 8, 2016

@oliverlockwood
Copy link
Contributor

@adamdougal can you take a look at this one please?

@adamdougal
Copy link
Contributor

adamdougal commented Nov 29, 2016

Kinda... Though I think it might be overkill to have a copy of all of the unit tests for each version. The change I'd make, is to move most of the unit tests to the cql module. Then just have a copy of the CqlMigratorImplTest in each of the testX modules so that it's tested end to end for each version.

As a minor thing, I'd probably rename the cql module to something different as it doesn't contain any cql, possible even just calling it cqlmigrate?

Good start though :)

@joseblas
Copy link
Contributor Author

joseblas commented Nov 29, 2016 via email

@adamdougal adamdougal removed their assignment Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants