Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull image logic #42

Open
edupo opened this issue Apr 7, 2018 · 1 comment
Open

Pull image logic #42

edupo opened this issue Apr 7, 2018 · 1 comment

Comments

@edupo
Copy link

edupo commented Apr 7, 2018

After #38 I had some comments I want to discuss with you let me know what you think:

When you want a docker image to be the latest version you usually do a pull image:latest or pull image but when you want to specify a fixed version like pull image:3.11 you probably don't want it to be updated to latest.

My suggestion, if there is no use case against it, will be to parse the image string and if it does not contain a tag or the tag is :latest then autoupdate. If a tag is specified then don't update until you specifically require it.

Tag can be found with a simple regular expression match with ':'

@lucymhdavies
Copy link

lucymhdavies commented Apr 7, 2018

So we have three possible behaviours for what to do if an image already exists with the tag:

  • Never Pull
  • Pull if :latest, but not if fixed version
  • Always pull

Personally, I prefer "Always Pull", but then I am almost never without internet access.
"Pull if :latest" does seem like a good option too. Might even be that this becomes the default, as it encourages people to create new tags for their images, rather than re-release an existing tag.

"Never Pull" definitely seems like a useful option, and is current behaviour.
For example, this is useful if you are in a low bandwidth situation, or even no internet connection at all., which is a use case I want to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants