Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress may halt at two mods left #13

Closed
skycatminepokie opened this issue Dec 12, 2024 · 1 comment
Closed

Progress may halt at two mods left #13

skycatminepokie opened this issue Dec 12, 2024 · 1 comment

Comments

@skycatminepokie
Copy link
Owner

skycatminepokie commented Dec 12, 2024

How we got here: choosing "banner text" as the problematic mod in whatever version of polymania I'm testing with. What seems to be happening is Banner Text is being chosen first - it has the least dependencies, due to the program counting deps of deps, even if those deps are provided in their parent. It depends on a module of FAPI, so FAPI is enabled. Hopefully this kind of thing is reduced by this fix, but a band-aid might be applied by checking if the previous list == this list, indicating that something went wrong (see #14).

@skycatminepokie
Copy link
Owner Author

Update: After fixing deps of deps that are parents or siblings being counted, it still happens. What needs to happen is if all mods are added to the testing set, we need to put them back in the candidate set, remove them from the testing set, and rotate the order they're in, then try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant