-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the fwd functionality to the API #1577
Conversation
In the last commit I added an additional endpoint: |
The last commit increases the write timeout for the Hypervisor API, to avoid problems with some of the new endpoints, which can be slow to respong. It also uses a single constant to define the write timeout in the 2 files were the timeout is set, to make the code easier to maintain. |
The last commit adds info about the local ports shared with FWD and the remote ports connected with REV to the summary API endpoint. |
The last commit adds an endpoint for turning off the visor. |
Did you run
make format && make check
?Can’t from my dev enviroment, will fix any problem form another machine if a problem appears.
Changes:
skywire-cli fwd
andskywire-cli rev
commands. This will allow to access the functionalities from the UI.How to test this PR:
Call the API endpoints, they should work as expected.
NOTE: during testing using Postman, when the
POST /visors/{pk}/rev
endpoint was called to create a connection, Postman it always reported that the server did not respond, but the connection was in fact created, which could be checked by callingGET /visors/{pk}/rev
. This could mean that the operation for creating the connection to the remote port is slow and that there is a timeout in the API that causes problems with that.