Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace dmsgget with dmsgcurl lib #1663

Merged
merged 2 commits into from
Nov 20, 2023
Merged

replace dmsgget with dmsgcurl lib #1663

merged 2 commits into from
Nov 20, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Oct 18, 2023 •
edited
Loading

Did you run make format && make check? Yes

Fixes: part of this PR: skycoin/dmsg#238

Changes:

  • update dmsg and use dmsgcurl instead dmsgget

How to test this PR:

  • trying to build skywire

Note:
I test and compile it on Ubuntu 22.04 and Golang version 1.20.7

@mrpalide mrpalide mentioned this pull request Oct 18, 2023
Merged
@mrpalide mrpalide marked this pull request as draft October 18, 2023 03:09
@mrpalide mrpalide marked this pull request as ready for review November 11, 2023 18:16
@jdknives jdknives merged commit 4c03bd4 into skycoin:develop Nov 20, 2023
3 checks passed
@mrpalide mrpalide deleted the fix/update-dmsg-for-using-dmsgcurl-instead-dmsgget branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrpalide @jdknives