Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue fetching data from hardcoded server #1666

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix issue fetching data from hardcoded server #1666

merged 1 commit into from
Nov 2, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Oct 24, 2023 •
edited
Loading

Did you run make format && make check? Yes

Fixes #1665 #1631

Changes:

  • change services on config structure from pointer to actual variable (fix nil pointer issue there)
  • improve condition on read from servers

How to test this PR:

  • on line 493 of cmd > skywire-cli > commands > config > gen.go replace serviceConfURL with arbitrary text for get error on trying to fetch
  • build and trying to generate config by ./build/skywire-cli config gen and check output, should be done without any panic and error

This was linked to issues Nov 2, 2023
Panic on fetch data from conf services #1665
Closed
panic on skywire-cli config gen (during deployment outage) #1631
Closed
@jdknives jdknives merged commit b6cad4e into skycoin:develop Nov 2, 2023
3 checks passed
@mrpalide mrpalide deleted the fix/handle-issue-on-fetch-data-for-generate-config branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic on fetch data from conf services panic on skywire-cli config gen (during deployment outage)
2 participants
@mrpalide @jdknives