From 94fcc51da8f325e8e355556de804f35e55e86e9f Mon Sep 17 00:00:00 2001
From: Simon Derr <ddrsimon@gmail.com>
Date: Tue, 7 May 2024 13:01:12 +0200
Subject: [PATCH] BitmapCalculator: fix use of a recycled bitmap

This commit fixes this warning message which happens with the HSV
color picker:

 "Called getWidth() on a recycle()'d bitmap! This is undefined behavior!"

It is likely due to the fact that createScaledBitmap() will usually
return a new bitmap, but will return the source bitmap if the dimensions
are the same.

This commit makes sure that scaleBitmap() will always return a new
bitmap.
---
 .../colorpicker/compose/BitmapCalculator.kt     | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/colorpicker-compose/src/main/kotlin/com/github/skydoves/colorpicker/compose/BitmapCalculator.kt b/colorpicker-compose/src/main/kotlin/com/github/skydoves/colorpicker/compose/BitmapCalculator.kt
index cc107bc..eac6735 100644
--- a/colorpicker-compose/src/main/kotlin/com/github/skydoves/colorpicker/compose/BitmapCalculator.kt
+++ b/colorpicker-compose/src/main/kotlin/com/github/skydoves/colorpicker/compose/BitmapCalculator.kt
@@ -30,12 +30,17 @@ internal object BitmapCalculator {
    * corresponding dimension of the target size.
    */
   internal fun scaleBitmap(bitmap: Bitmap, targetSize: IntSize): Bitmap {
-    return Bitmap.createScaledBitmap(
-      bitmap,
-      targetSize.width,
-      targetSize.height,
-      false,
-    )
+    val sameSize = (targetSize.height == bitmap.height && targetSize.width == bitmap.width)
+    return if (sameSize) {
+      bitmap.copy(bitmap.config, bitmap.isMutable)
+    } else {
+      Bitmap.createScaledBitmap(
+        bitmap,
+        targetSize.width,
+        targetSize.height,
+        false,
+      )
+    }
   }
 
   /**