Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnoticed error generation #17

Open
shreyass-ranganatha opened this issue Jun 8, 2022 · 1 comment
Open

Unnoticed error generation #17

shreyass-ranganatha opened this issue Jun 8, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@shreyass-ranganatha
Copy link
Contributor

shreyass-ranganatha commented Jun 8, 2022

File: ed_analytics/github.py
Method: Repository.get_commits()

the function get_commits() fails to check the request's response code, and hence tries to work with whatever response comes out. Need an implementation for a check for response code and a thoughtful work through further

@shreyass-ranganatha
Copy link
Contributor Author

Example; when GitHub REST API requests reach a rate-limit, the error risen would be "TypeError: list indices must be integers or slices, not str."

We need it to specify the message that GitHub REST API poses

@shreyass-ranganatha shreyass-ranganatha added the bug Something isn't working label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant