From 31aa76c968e6c9ca8c21ac25051f002383c1baee Mon Sep 17 00:00:00 2001 From: Tian Xia Date: Fri, 10 Nov 2023 16:42:35 -0800 Subject: [PATCH] [BugFix] Fix GCP Cloud Permission doc url (#2770) fix --- sky/backends/cloud_vm_ray_backend.py | 2 +- sky/clouds/gcp.py | 2 +- sky/skylet/providers/gcp/constants.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py index c9c80da03e5..b1832d6581f 100644 --- a/sky/backends/cloud_vm_ray_backend.py +++ b/sky/backends/cloud_vm_ray_backend.py @@ -769,7 +769,7 @@ def _update_blocklist_on_gcp_error( 'having the required permissions and the user ' 'account does not have enough permission to ' 'update it. Please contact your administrator and ' - 'check out: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions.html#gcp\n' # pylint: disable=line-too-long + 'check out: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions/gcp.html\n' # pylint: disable=line-too-long f'Details: {httperror_str[0]}') self._blocked_resources.add( launchable_resources.copy(region=None, zone=None)) diff --git a/sky/clouds/gcp.py b/sky/clouds/gcp.py index df73d46316a..98d8403528e 100644 --- a/sky/clouds/gcp.py +++ b/sky/clouds/gcp.py @@ -860,7 +860,7 @@ def check_credentials(cls) -> Tuple[bool, Optional[str]]: 'The following permissions are not enabled for the current ' f'GCP identity ({identity_str}):\n ' f'{diffs}\n ' - 'For more details, visit: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions.html#gcp') # pylint: disable=line-too-long + 'For more details, visit: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions/gcp.html') # pylint: disable=line-too-long return True, None def get_credential_file_mounts(self) -> Dict[str, str]: diff --git a/sky/skylet/providers/gcp/constants.py b/sky/skylet/providers/gcp/constants.py index bcf3b02ef70..c6f02e8af9b 100644 --- a/sky/skylet/providers/gcp/constants.py +++ b/sky/skylet/providers/gcp/constants.py @@ -80,7 +80,7 @@ ] # A list of permissions required to run SkyPilot on GCP. -# Keep this in sync with https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions.html#gcp # pylint: disable=line-too-long +# Keep this in sync with https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions/gcp.html # pylint: disable=line-too-long VM_MINIMAL_PERMISSIONS = [ "compute.disks.create", "compute.disks.list",