Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Get rid of signal handling #2182

Closed
Michaelvll opened this issue Jul 6, 2023 · 2 comments · Fixed by #2252
Closed

[core] Get rid of signal handling #2182

Michaelvll opened this issue Jul 6, 2023 · 2 comments · Fixed by #2252
Labels
bug Something isn't working

Comments

@Michaelvll
Copy link
Collaborator

We currently use signal handling in our backend to kill the child processes immediately after keyboard interrupt is sent and print the hints. However, this will cause sky.launch not able to be run in a non-main thread. This is a bug encountered by a user, and we should look into it.

signal.signal(signal.SIGINT, backend_utils.interrupt_handler)
signal.signal(signal.SIGTSTP, backend_utils.stop_handler)

@Michaelvll Michaelvll added the bug Something isn't working label Jul 6, 2023
@concretevitamin
Copy link
Member

Just ran into this too when trying out #2235.

@concretevitamin
Copy link
Member

A user reported they sometimes ran into this during sky.launch(), with the two detach flags set to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants